Preview of the new coordinates: mpickering#9 (comment)

I wonder if the coordinates for the mines transport are slightly wrong?

Preview of the new coordinates: mpickering#9 (comment)

I wonder if the coordinates for the mines transport are slightly wrong?

They seem to be correct, I even tested a few paths back then.

It would be nice if you could just write the names rather than numeric identifiers!

This is possible for some items, but they have to be listed in ItemVariations.java (it's a side product of that functionality).

Looks good @rmobis ! Do you have anything else you wanted to add (as your last commit was two days ago), or can I start reviewing and merging?

It would be nice if you could just write the names rather than numeric identifiers!

This is possible for some items, but they have to be listed in ItemVariations.java (it's a side product of that functionality).

Looks good @rmobis ! Do you have anything else you wanted to add (as your last commit was two days ago), or can I start reviewing and merging?

@FIrgolitsch Feel free to review. I have some other stuff I want to work on, but I'll create a separate branch and PR for those in the future.

Alright! I'll have an in-depth look sometime this weekend!

I've updated the PR to resolve the conflicts

Actually, this can be simplified by just adding the battered key to the item requirements. It’s an untradable item which is fully tied to the quest to obtain it for the first time.

Will that work with the steel key ring?

Edit: Also, only the door requires the key, not the stairs

I added it to everything as a way to make sure it's there, but you're right, only the door needs it. Good point about the steel ring, lemme quickly check how that works internally.

Added the steel key ring to the requirements as well. At the moment it assumes that the key is on the ring as there's currently not a way to check what the contents of the ring are. It would either require some caching or varbit checks, but that requires some more in depth work.

No problem, I think this is a good compromise. I might take a look at that at some point.

I expect that one to be difficult as all these items seem to be hard to interact with programmatically.

Anyway, looks good otherwise, thanks! I'll merge it right away,